Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially maintained on npm? #48

Open
kennynaoh opened this issue Jul 13, 2016 · 10 comments
Open

Officially maintained on npm? #48

kennynaoh opened this issue Jul 13, 2016 · 10 comments

Comments

@kennynaoh
Copy link
Contributor

Hello @darklow ,
I am the member of cdnjs project.
We want to host this library.
There is a question want to ask.
Is this library officially maintained on npm?
Because I saw the latest release version on github is v1.0.9, and the latest release version on npm is v1.0.8
Please help confirm that.
Thanks for your help!

cdnjs/cdnjs#8505

@darklow
Copy link
Owner

darklow commented Jul 13, 2016

Originally @alexandernst added NPM support, but he transferred npm package ownership back to me. I would love to update npm if I could, receiving error on publish, I have no idea why and haven't found a solution yet:

$ npm publish ./
npm ERR! Darwin 15.5.0
npm ERR! argv "/usr/local/Cellar/node/6.3.0/bin/node" "/usr/local/bin/npm" "publish" "./"
npm ERR! node v6.3.0
npm ERR! npm  v3.10.5

npm ERR! Path must be a string. Received [ 'dist/js/social-share-kit.min.js',
npm ERR!   'dist/css/social-share-kit.css' ]

@alexandernst
Copy link
Contributor

Just change

to

"main": "dist/js/social-share-kit.min.js"

(It's an array now, which NPM started to hate recently...)

@darklow
Copy link
Owner

darklow commented Jul 13, 2016

Thank you @alexandernst
@kennynaoh just pushed recent version to npm as well: https://www.npmjs.com/package/social-share-kit

@darklow
Copy link
Owner

darklow commented Jul 13, 2016

@kennynaoh Social share kit also requires .CSS fail along with .JS file. How can it be obtained from npmjs if there is no mention about in package.json? I am not familiar with cdnjs submit process.

@alexandernst
Copy link
Contributor

@darklow NPMJS is just a registry. You upload the entire package, not just the file listed in main.

@darklow
Copy link
Owner

darklow commented Jul 13, 2016

Oh sorry @alexandernst and @kennynaoh, i meant how does cdnjs knows which files to include if there is no mention of .CSS file in package.json.

As an answer to the original question - yes this is officially maintained on npm.

@alexandernst
Copy link
Contributor

All files (recursively) from the directory where the package.json file is
located are included in the package.
El El mié, 13 jul 2016 a las 20:28, Kaspars Sprogis <
[email protected]> escribió:

Oh sorry @alexandernst https://github.com/alexandernst and @kennynaoh
https://github.com/kennynaoh, i meant how does cdnjs knows which files
to include if there is no mention of .CSS file in package.json


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAFef_b_ALUnAS6_-2S1YTgbN7ANC9Zzks5qVS5HgaJpZM4JLf5B
.

@kennynaoh
Copy link
Contributor Author

Thanks @darklow , @alexandernst ,
Sorry for late reply.
@darklow I found that the latest release on github is v1.0.10, but the latest release on npm is v0.9.0.
Please help me publish the latest version on npm, then I will host this library.
Thank you!

@darklow
Copy link
Owner

darklow commented Sep 10, 2016

Published latest version to npm:
https://www.npmjs.com/package/social-share-kit

@kennynaoh
Copy link
Contributor Author

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants