Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass version #58

Open
yumyo opened this issue Jan 9, 2017 · 3 comments
Open

Sass version #58

yumyo opened this issue Jan 9, 2017 · 3 comments

Comments

@yumyo
Copy link

yumyo commented Jan 9, 2017

I know, it's a tough job but someone's got to do it )
Would you accept a pull request for it ?

@darklow
Copy link
Owner

darklow commented Jan 9, 2017

You mean as alternative or replacement?
It would be great to have sass version and I would consider PR, but can't promise approval, since it depends on quality of your code. I moved to sass too, since bootstrap decided to go with sass, but so far I just renamed dist/social-share-kit.css to .sass and include it in my lib and do override if I needed any fixes.

@yumyo
Copy link
Author

yumyo commented Jan 9, 2017

both approaches are fine but the former implies to keep supporting both, though.
Anyway, looking at the code the conversion looks like quite simple with small differences. I'll put my hands on it this weekend and send you a PR for review.

@darklow
Copy link
Owner

darklow commented Jan 9, 2017

Ok, let's keep both for a while.
Thank you.

tony added a commit to develtech/social-share-kit that referenced this issue Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants