Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish docs #83

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Polish docs #83

merged 1 commit into from
Feb 20, 2024

Conversation

whatyouhide
Copy link
Collaborator

Added docs to the callbacks in BroadwaySQS.SQSClient and minor fixes here and there.

Unrelated question @josevalim @msaraiva: can we make BroadwaySQS.Options private, or only expose definition/0?

@josevalim
Copy link
Member

I think we should make it fully private, yeah.

@whatyouhide whatyouhide merged commit 055e9a5 into main Feb 20, 2024
1 of 2 checks passed
@whatyouhide whatyouhide deleted the docs branch February 20, 2024 15:57
@whatyouhide
Copy link
Collaborator Author

Done in fb517d7 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whatyouhide @josevalim