Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove addtime default and add ability to compute kth distance #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lingyiyang
Copy link
Collaborator

There are two suggested changes:

  1. Remove the addtime augmentation as a default. The data that users input may already have a time channel, and this default behaviour is unexpected. Some existing examples may have to be altered.
  2. Change the computation of the conformance score to include an extra parameter called kth, this enables us to find the kth closest neighbour rather than always returning the nearest neighbour. This is in addition to the n_neighbors parameter as the latter finds n neighbours in the projected subspace, once the distance away from the subspace is taken into account, the ordering of the neighbors will change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant