Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of flarum/core (1.8.4) broke the build #9

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 15, 2023

We've tested your project with an updated dependency and the build failed.

This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.

name version specification new version
flarum/core ^1.2.0 1.8.4

Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.

If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)

We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of flarum/core for this test run.

What changed?

✳️ flarum/core (^1.2.0 → 1.8.4) · Repo · Changelog


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Dec 15, 2023
@datlechin datlechin merged commit 52d313a into master Jan 20, 2024
6 of 7 checks passed
@depfu depfu bot deleted the depfu/check/composer/flarum/core-1.8.4 branch January 20, 2024 14:52
@rob006
Copy link

rob006 commented Jun 13, 2024

@datlechin this change is incorrect, it should be ^1.8.4 if you really want to bump requirements for this extensions. Right now this extension will prevent updates to Flarum 1.8.5.

@datlechin
Copy link
Owner

@rob006 I appreciate your notice. I will revert this

datlechin added a commit that referenced this pull request Jun 13, 2024
datlechin added a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants