Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional changes to the preview image #18

Merged
merged 11 commits into from
Jan 12, 2023

Conversation

naxvog
Copy link
Contributor

@naxvog naxvog commented Jan 12, 2023

  • FA Icon if the Google API is not found
  • No empty container when no image is found and Google API is not used

@datlechin
Copy link
Owner

Conflict 😅

A small Git tip: checkout to the master branch and git pull before do an awesome thing

@naxvog
Copy link
Contributor Author

naxvog commented Jan 12, 2023

Parallel PRs concerning the same file(s) will most likely result in a conflict 😉 updated from the upstream master

@datlechin
Copy link
Owner

Thanks! I’ll test this later and make a release

@datlechin datlechin merged commit b816f87 into datlechin:master Jan 12, 2023
@naxvog naxvog deleted the fix-preview-image-2 branch February 10, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants