Various changes #20
Merged
Various changes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d58cd0d.
|
Could you delete the dist folder? |
|
Thank you <3 |
datlechin
approved these changes
Feb 8, 2023
datlechin
reviewed
Feb 10, 2023
| @@ -42,7 +49,7 @@ export default class LinkPreview extends Component { | |||
| } | |||
|
|
|||
| getLink(text) { | |||
| return m('a', this.linkAttributes, text); | |||
| return <Link {...this.linkAttributes}>{this.loading ? this.getDomain() : text ?? this.getDomain()}</Link>; | |||
There was a problem hiding this comment.
There's a problem here that I didn't notice before, the Link component cannot be redirected to the destination page. I'll fix it
There was a problem hiding this comment.
Could you please elaborate on that using an example? I tested the Component and found no issue on my dev installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsed around some Flarum components and integrated some of them to increase general standardization of the extension:
refreshContentto include post updates as well (triggers right after a post was edited without a page refresh)