-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various changes #20
Various changes #20
Conversation
This reverts commit d58cd0d.
Could you delete the dist folder? |
Thank you <3 |
@@ -42,7 +49,7 @@ export default class LinkPreview extends Component { | |||
} | |||
|
|||
getLink(text) { | |||
return m('a', this.linkAttributes, text); | |||
return <Link {...this.linkAttributes}>{this.loading ? this.getDomain() : text ?? this.getDomain()}</Link>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a problem here that I didn't notice before, the Link
component cannot be redirected to the destination page. I'll fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please elaborate on that using an example? I tested the Component and found no issue on my dev installation.
Browsed around some Flarum components and integrated some of them to increase general standardization of the extension:
refreshContent
to include post updates as well (triggers right after a post was edited without a page refresh)