Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Group Permission protection using the dropdown option as the Group Check detection #10

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

Yippy
Copy link
Contributor

@Yippy Yippy commented Feb 17, 2024

This PR is to allow only specific Group permission to access tag discussion, by reusing Password logic.
image

Within Tag edit modal there is an added protection for the new Group protection checkbox
image
image

Sidebar will have new icon for Group Permission tags.
image

Added new settings options for Tag Passwords extension page.

  1. Give Admin a choice to display unlocked icon next to tag name, for notification that these tags are restricted access.
  2. Give Admin a choice to hide protected tags from sidebar navigation.
    image
    image
  3. Give Admin a choice to display protected tags within the Tags Page, otherwise it be hidden from User

image
image

…Group check.

Improve user awareness for identifying protected tags
Hide and mask latest discussion within protected tags when viewing Tags Page
@datlechin
Copy link
Owner

Thank you for submitting the PR.

The current code adds a new field called group to enter the name of the permission group, this is quite difficult to use. It would be better to allow users to select the available permission groups using a dropdown.

Changed SQL column of 'group' to 'protected_group_ids'

protected_group_ids is used as a string for storing list of Group IDs
@Yippy
Copy link
Contributor Author

Yippy commented Feb 19, 2024

chrome-capture-2024-2-19
@datlechin I've implemented a dropdown selection option, the column now store Group IDs as a example '1,4' is for Admin (ID 1) and Mod (ID 4).

I've dropped the column 'group' to 'protected_group_ids'

@Yippy
Copy link
Contributor Author

Yippy commented Feb 19, 2024

Adding Permission Group for editing Tag
Here is an example of removing and adding groups

@Yippy
Copy link
Contributor Author

Yippy commented Feb 21, 2024

I've amended the protected group, instead of string use JSON instead.
That way it can be future feature proof, if you really wanted you can add a new feature that each of the protected group with an individual password, but just having group detection is suffice for my use case.

Copy link
Owner

@datlechin datlechin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@datlechin
Copy link
Owner

datlechin commented Feb 21, 2024

@Yippy can you merge to the main branch to resolve the conflict issue

@Yippy Yippy changed the title Implement Group Permission protection using the singular name as the Group Check detection Implement Group Permission protection using the dropdown option as the Group Check detection Feb 21, 2024
@Yippy
Copy link
Contributor Author

Yippy commented Feb 21, 2024

image
Not sure how to fix these conflicts, the PR is for datlechin:main

@datlechin datlechin merged commit 5be22ad into datlechin:main Feb 21, 2024
3 of 4 checks passed
@Yippy
Copy link
Contributor Author

Yippy commented Feb 21, 2024

Thanks for merging 😄, I forgot to amend the README to show the new added feature. Seems like a lot of formatting and changes has to be done on your end, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants