-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Group Permission protection using the dropdown option as the Group Check detection #10
Conversation
…Group check. Improve user awareness for identifying protected tags Hide and mask latest discussion within protected tags when viewing Tags Page
Thank you for submitting the PR. The current code adds a new field called group to enter the name of the permission group, this is quite difficult to use. It would be better to allow users to select the available permission groups using a dropdown. |
Changed SQL column of 'group' to 'protected_group_ids' protected_group_ids is used as a string for storing list of Group IDs
I've dropped the column 'group' to 'protected_group_ids' |
I've amended the protected group, instead of string use JSON instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@Yippy can you merge to the |
|
Thanks for merging 😄, I forgot to amend the README to show the new added feature. Seems like a lot of formatting and changes has to be done on your end, thanks again. |
This PR is to allow only specific Group permission to access tag discussion, by reusing Password logic.
![image](https://private-user-images.githubusercontent.com/6518915/305593587-dfeb1913-0f29-4cbf-b33d-38d4c925e70e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNjUxMjUsIm5iZiI6MTcyNjA2NDgyNSwicGF0aCI6Ii82NTE4OTE1LzMwNTU5MzU4Ny1kZmViMTkxMy0wZjI5LTRjYmYtYjMzZC0zOGQ0YzkyNWU3MGUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMTQyNzA1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmFiZmRjZmZjMDhmNGEzZTQzYTMyMzE5MDk1ODNjYmRhMDBlOGRkODIxMTRjNmI0YTJlOTk0ODg0MzdhNDlkMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.d_l-BOrykDD3ikzA3N6yvY92yM0k5ugdx8SWqnB1GvM)
Within Tag edit modal there is an added protection for the new Group protection checkbox
![image](https://private-user-images.githubusercontent.com/6518915/305593349-76b1eeab-90c7-455e-bf61-7da31175fb04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNjUxMjUsIm5iZiI6MTcyNjA2NDgyNSwicGF0aCI6Ii82NTE4OTE1LzMwNTU5MzM0OS03NmIxZWVhYi05MGM3LTQ1NWUtYmY2MS03ZGEzMTE3NWZiMDQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMTQyNzA1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTdlMzhlNGNhYjA5ZWY1NTQ3ODhmMjI1YjUwNWYxYjZmYzgzNzNmYjE0YjBlYzZhZjYzNjgwMTZkOGQ3MmFmYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.G40M04ijnljCdFH0nSGoS3A9Ayrd34LlW96xCaFdIA0)
![image](https://private-user-images.githubusercontent.com/6518915/305593380-6295b9be-29eb-4c7b-8d49-50814cbf3146.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNjUxMjUsIm5iZiI6MTcyNjA2NDgyNSwicGF0aCI6Ii82NTE4OTE1LzMwNTU5MzM4MC02Mjk1YjliZS0yOWViLTRjN2ItOGQ0OS01MDgxNGNiZjMxNDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMTQyNzA1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjNkNWMwMWMzZGVmNjQxNTAyNGNkMDY4ZDhjYzAzNjhkY2M0YzJhNzU0NDdmYTUyNzU5YjEwZTIxZjdkNTRhOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.53CplWfVCgI1xBbb7vEHe_YX8JAT6xIAMFfUqDdPgfM)
Sidebar will have new icon for Group Permission tags.
![image](https://private-user-images.githubusercontent.com/6518915/305593411-b0ef8afb-522c-4758-a7ec-d9422a718152.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNjUxMjUsIm5iZiI6MTcyNjA2NDgyNSwicGF0aCI6Ii82NTE4OTE1LzMwNTU5MzQxMS1iMGVmOGFmYi01MjJjLTQ3NTgtYTdlYy1kOTQyMmE3MTgxNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMTQyNzA1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzkwODkxZjdjYzhkY2M2MjIyZTA2Y2NkM2YyZTI2YzBmMzE1NWU4MTE1MWIxNzJlMDVmZjNhZmUzMjBlMGFkZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.6K8u_puM5UqNU8RWHKMOTqUPr67dntqlszCPzPIfmRY)
Added new settings options for Tag Passwords extension page.