-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Restriction for Tag Protected Discussions #14
Conversation
…n to select roles on which settings.
Cleanup index.js for forum with extended functions files to separate extended or override sections.
…r not loading extended Tag. Instead create ProtectedTag instances for usage in tagLabel and tagsLabel
…switch, able to display different view for different User Permission Groups Added ReferrerFinder helper class to find which section is the API is loaded from Added User Policy to simplify the isUnlocked logic. Added tooltipForPermission helper class to produce tooltip for both Post and Discussion List for Protected Tags
…scussion and Posts Added restricted view of Discussion Title and Post Contents for protected tags.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic Password | 33580c6 | js/dist/forum.js | View secret | |
- | Generic Password | 33580c6 | js/dist/forum.js | View secret | |
- | Generic Password | 33580c6 | js/dist/forum.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Thank you for your contribution! It looks great. I'll go ahead and merge your changes and credit you as the contributor for this extension. P.S: For your next PR, you won't need to push files in the |
Please wait, I found a bug |
I'll mark the PR as a draft. Once you're finished, you can mark it as ready for review. |
I've fixed the issue when using Theme extension that doesn't like null string, this is now ready. I haven't updated the dist with the latest changes. |
…stsUserPage styling
PR is ready, tidied most it now. |
Thank you! |
Closed #12 #13
New Permissions Settings
Toggle user group for each settings, instead of using a on or off switch.
![image](https://private-user-images.githubusercontent.com/6518915/329314120-996f1543-346d-4f1f-baba-3e1bfb0b50e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNjA1MTIsIm5iZiI6MTcyNjA2MDIxMiwicGF0aCI6Ii82NTE4OTE1LzMyOTMxNDEyMC05OTZmMTU0My0zNDZkLTRmMWYtYmFiYS0zZTFiZmIwYjUwZTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMTMxMDEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTIwMzczMzBjNjNlNDUxZDkzODkzN2VkZWRlMjhjODljMzAxYjVkMTI0MTExZmJiNWIzZTFkZjFmYmY2MzdlMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.jpY7UEtIWKNEGMG1teBVXNtjcdNCKTUi5zjTykax_WI)
Provide Access for Sharing Link depending on User Roles
Everyone
![image](https://private-user-images.githubusercontent.com/6518915/329314486-2d2410e8-ecaf-407a-bd56-3cd3ba159a20.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNjA1MTIsIm5iZiI6MTcyNjA2MDIxMiwicGF0aCI6Ii82NTE4OTE1LzMyOTMxNDQ4Ni0yZDI0MTBlOC1lY2FmLTQwN2EtYmQ1Ni0zY2QzYmExNTlhMjAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMTMxMDEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDE3NmQ4ZDExZGMyMGQ2YmQ0MmVmNjg4NDc3MWM0ZmQwZjZlMzBjYzRmYTFiYzg1MDk4ZjI2ZjczNjViNTJjYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.BXvY8ebLXTkoSYFHGKOkSybkdRyaSKetFCEbETmdS_g)
![image](https://private-user-images.githubusercontent.com/6518915/329314794-1342143d-0765-41d1-916c-363ca71c5c04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNjA1MTIsIm5iZiI6MTcyNjA2MDIxMiwicGF0aCI6Ii82NTE4OTE1LzMyOTMxNDc5NC0xMzQyMTQzZC0wNzY1LTQxZDEtOTE2Yy0zNjNjYTcxYzVjMDQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMTMxMDEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzFlNTY0MGMyYTVmNGIwOGQyM2JlZGVjYmEyNGY1NmY3MTJmYTJjYTAwNDE1MDQwNGJiZTkzYTZjOWUwZGFiMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.pitnGIHeAUy0ntjAaFJx0FIpwRRjHSBpJIAq_6gme40)
Admin Only
User Page Post Page is now protected, you can choose to show the protected
Data API is now restricted for protected Tags
The data is still displaying IDs for objects, but the details are now cleared from view. Please note that API will pretty much strip all data away, unless you are viewing the Discussion Page with the Correct User role for URL Sharing.
![image](https://private-user-images.githubusercontent.com/6518915/329316005-8eb91277-b920-4b12-8d0f-f1ba0be1e8a9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNjA1MTIsIm5iZiI6MTcyNjA2MDIxMiwicGF0aCI6Ii82NTE4OTE1LzMyOTMxNjAwNS04ZWI5MTI3Ny1iOTIwLTRiMTItOGQwZi1mMWJhMGJlMWU4YTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMTMxMDEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDAyN2ExYmFmZGMzYmFmZDMyZmY0NTBlYmQzMmQxZTA1YmE4NGMwODFjMTBiZjQ1MjhjMjg3YjlkNTk1ZDIxOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.bPlryYDmsfhgx3vvukf0azptACcQ_FoKVpaxc8EUdiE)