Support assisted injection #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daugeldauge
reviewed
Dec 5, 2023
|
|
||
| @Retention(AnnotationRetention.SOURCE) | ||
| @Target(AnnotationTarget.CONSTRUCTOR) | ||
| annotation class AssistedInject |
| val assistedFactoryTypes = resolver.getSymbolsWithAnnotation(AssistedFactory::class.requireQualifiedName()) | ||
| .mapNotNull { assistedFactoryDeclaration -> | ||
| if (assistedFactoryDeclaration !is KSClassDeclaration || !assistedFactoryDeclaration.isAbstract()) { | ||
| logger.error("@AssistedFactory can be applied only to abstract types", assistedFactoryDeclaration) |
There was a problem hiding this comment.
Could you add tests for all new errors? (see ProcessorErrorsTest)
|
|
||
| if (assistedSourceParameters != assistedFactoryParameters) { | ||
| throw NonRecoverableProcessorException( | ||
| "Factory method in @AssistedFactory must have assisted parameters by same names, types and in the same order as @AssistedInject constructor", |
There was a problem hiding this comment.
I think I'd be a little better if this logic (and annotation matching above) was somewhere outside the generator.
There was a problem hiding this comment.
Done - extracted to a separate utility object AssistedFactoryDependenciesResolver
vganin
force-pushed
the
assisted-inject
branch
from
0b08789
to
510fe4b
Compare
daugeldauge
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same semantics as in Dagger 2 with minor changes:
@Assistedannotation since there is not problem in disambiguating parameters with the same type simply by name using KSP (original Dagger 2 issue).Closes #6