-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic xterm emulation #201
Draft
davidrg
wants to merge
20
commits into
master
Choose a base branch
from
xterm-emu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not enabled by default (build with CKF_XTERM_EMULATION=yes Also made it possible to build with VT420 and VT520 emulation options (in theory), though there is currently no VT520 stuff implemented and very little VT420 so not much point in turning these on.
Certain escape sequences were probably able to trigger and out-of-bounds array access.
Perhaps some later VT terminals do too? The xterm paths haven't been implemented yet but at least the wrong thing won't happen now if something tries to do, eg, double-underline.
Now passes all tests
KUI is not available on OS/2 so KuiGetTerminalMaximisedSize isn't either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at a usable emulation of xterm. In particular, a terminal type that passes most of the tests in esctest2 (https://github.com/ThomasDickey/esctest) and supports a reasonable subset of xterms extensions. The goal is maximum achievable compatibility with xterm, enough that using TERM=xterm doesn't cause any issues for a vast majority of applications.
Why? Because CKW has only emulation options. There is no "ckw" terminal type that turns on all available features, and even if there were there is the challenge of getting that terminal type into every terminfo database on every machine in the world. Faced with this same challenge a lot of other terminal emulators, eg PuTTY, just claim to be xterm. We're going to aim to do a better job of matching xterms behaviour though.
In order to be merged:
In order to be in a releasable state, the xterm emulation option really needs to support:
set term send-data on
It would also be nice to support these extensions and other features, though perhaps not strictly necessary for a first version:
We also need to document what exactly the "xterm" terminal type is:
We should also probably sort out some other emulation issues while we're here: