-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative method to Utils optional options #169
Alternative method to Utils optional options #169
Conversation
@davidusb-geek |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 88.54% 89.96% +1.41%
==========================================
Files 6 6
Lines 1668 1644 -24
==========================================
+ Hits 1477 1479 +2
+ Misses 191 165 -26 ☔ View full report in Codecov by Sentry. |
This option seems much more elegant. Nice work. |
The bugs from this comment are also solved on this PR. |
In testing it seemed to fix the issue also. Will do a double check now to be double sure. |
I think that we will push up this method, if everything works correctly. |
Tested, looks like everything works. Actually found an bug when setting solar_forecast_kwp to 0 so added a patch fix (feel free to revert once pulled) |
hangon. may of found another bug. Looking at it now. Edit: I think I know why |
@davidusb-geek Should be good to go now 👍 |
Great! +1 |
params['plant_conf']['SOCmax'] = options.get('battery_maximum_state_of_charge',params['plant_conf']['SOCmax']) | ||
params['plant_conf']['SOCtarget'] = options.get('battery_target_state_of_charge',params['plant_conf']['SOCtarget']) | ||
|
||
params['associations_dict'] = associations_dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So why save this association dict, it will be used elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do. For testing. We check that options parameters are properly overriding the default config.
My method so far to make sure something didnt go crazy in the commit.
No description provided.