-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: interpret load sensors in kW rather than W #292
base: master
Are you sure you want to change the base?
Conversation
Hi, thanks for working on this. |
So to solve this probably break it into two new variables, something like: |
Thanks for reviewing! Your comments make sense. |
…ly. modified methods that take runtime parameters to accept a var_model_in_kw boolean for the same purpose.
Please check how this version looks like to you. I've split the unit flags and I've added the same option to the methods that take the sensors as runtime parameters. The concept is that these apply only when collecting info from HA, cached data should be kept in W, so methods that read off files shouldn't be checking the flags. |
if "var_model_in_kw" not in runtimeparams.keys(): | ||
var_model_in_kw = False | ||
else: | ||
var_model_in_kw = eval(str(runtimeparams["var_model_in_kw"]).capitalize()) |
Check failure
Code scanning / CodeQL
Code injection Critical
user-provided value
This code execution depends on a
user-provided value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
identical situation to other runtimeparams including other boolean flags
Unit tests are failing. This doesn't seem ready yet? |
Hello David, apologies I am not used to working with GitHub or pull request
etiquette. Should I undo the pull request until it is clean and ready to
go? Is there a way to run the unit tests outside of this interface? Thanks,
Pedro.
…On Sat, 1 Jun 2024, 18:10 David, ***@***.***> wrote:
Unit tests are failing. This doesn't seem ready yet?
—
Reply to this email directly, view it on GitHub
<#292 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APVEFGQF6QHMQH7ZV6QBGP3ZFH6ANAVCNFSM6AAAAABIHZXT46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGUYTOMZYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No problem. For me Method 1 locally works just fine. |
I took a look and tried to implement a switch that has load sensors interpreted as kW rather than W. I ran the tests and the optimisation process and I think it is working. Anything else I should be testing for? Thanks in advance.