Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move croact from devDependencies to dependencies in croact-css-styled #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wxgisu
Copy link

@wxgisu wxgisu commented Jun 3, 2024

croact is used in an import statement in styled.d.ts file in the croact-css-styled package, but it is included as devDependencies instead of dependencies. This causes vite build and vite dev failures when the package is used in a pnpm monorepo. See detailed explanation in another related pr: daybrush/moveable#1115

Fixing the issue by moving croact from devDependencies to dependencies in the croact-css-styled package.

@wxgisu wxgisu marked this pull request as ready for review June 3, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant