Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Prepare for metadata-only resolves #113

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Conversation

ddelange
Copy link
Owner

@ddelange ddelange commented Aug 9, 2023

With a lot of excitement, adding support for pip's new --dry-run --report functionality.

With this PR, a wheel download is no longer necessary if:

Closes #40 🎉

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch coverage: 57.69% and project coverage change: -0.28% ⚠️

Comparison is base (812db2b) 78.16% compared to head (cc4f9d5) 77.88%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   78.16%   77.88%   -0.28%     
==========================================
  Files          29       29              
  Lines        2807     2831      +24     
  Branches      789      794       +5     
==========================================
+ Hits         2194     2205      +11     
- Misses        440      448       +8     
- Partials      173      178       +5     
Files Changed Coverage Δ
src/pipgrip/pipper.py 78.08% <57.69%> (-2.53%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddelange ddelange force-pushed the metadata-only-resolve branch 2 times, most recently from 06620d4 to 7f2edf5 Compare August 9, 2023 11:10
@ddelange ddelange merged commit d7f2f2b into master Aug 9, 2023
11 of 12 checks passed
@ddelange ddelange deleted the metadata-only-resolve branch August 9, 2023 11:15
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Released 0.10.5

@LanYuqiao
Copy link

Does that mean pipgrip won't fetch and build wheel from now on?

@ddelange
Copy link
Owner Author

ddelange commented Sep 21, 2023

Hi @LanYuqiao 👋

Yes, with a few prerequisites:

edit: moved to PR description

@LanYuqiao
Copy link

@ddelange Thanks for the works! That's a great job:->👍

@LanYuqiao
Copy link

And I think the main page README should update the fetch/build description

@ddelange
Copy link
Owner Author

True, I'll update the README once the pip PR merges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there any chance of discovering package dependencies without building wheels?
3 participants