Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Add support for extras_require #8

Merged
merged 11 commits into from
Jan 23, 2020
Merged

♻️ Add support for extras_require #8

merged 11 commits into from
Jan 23, 2020

Conversation

ddelange
Copy link
Owner

@ddelange ddelange commented Jan 23, 2020 •
edited
Loading

part 1:

  • there is some extras_require down the tree (e.g. at depth 3), which needs to be properly propagated

part 2:

  • aiobotocore is root_dep, but other root_dep depends on aiobotocore[boto3]
  • aiobotocore[awscli] is root_dep, but other root_dep depends on aiobotocore[boto3]

@ddelange
📝 Add TODO comment in README.md
dbd8e7f
@ddelange
♻️ Add support for extras_require (part 1)
9d0e611 
Only need solution when e.g. aiobotocore is root_dep, but other root_dep depends on aiobotocore[boto3]
@ddelange
🐛 Fix discover_and_add in dependencies_for
792ff49
@ddelange
Merge branch 'master' of https://github.com/ddelange/pipgrip into fixes
445a3d5 
* 'master' of https://github.com/ddelange/pipgrip:
  ➕ Add backports for enum and typing modules (#7)
  💚 Upgrade GitHub actions/checkout@v1 --> v2 (#5)
@ddelange
⚡ Remove the maximum for amount of packages to try
e9f469f
@ddelange
🐛 Broaden support for pip~=20.0
c376a1e
@ddelange
♻️ Add support for extras_require (part 2)
f00527b
@ddelange
🐛 Add __ne__ to Package for proper Package comparison in py2
f712b73
@ddelange
🐛 Handle case where _non_empty_term returns None
5ac7c63
@ddelange
🚨 Make lint compliant
e3fe8ee
@ddelange
📝 Add comparisons to README.md
32601b3
@ddelange ddelange merged commit d712b9d into master Jan 23, 2020
@ddelange ddelange deleted the fixes branch January 23, 2020 15:23
@ddelange ddelange mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ddelange