feat: move NavbarPagesUrls to config

decentraland · Jul 15, 2024 · 28c62bd · 28c62bd
1 parent b9e6268
commit 28c62bd
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/src/components/Navbar/MainMenu/MainMenu.tsx b/src/components/Navbar/MainMenu/MainMenu.tsx
@@ -1,6 +1,7 @@
 import React from 'react'
 import classNames from 'classnames'
 
+import { config } from '../../../config'
 import { MenuItem } from '../MenuItem/MenuItem'
 import { NavbarPages, NavbarPagesUrls } from '../Navbar.types'
 import { MainMenuProps } from './MainMenu.types'
@@ -22,31 +23,35 @@ export const MainMenu = (props: MainMenuProps) => {
         {...menuItemProps}
         section={NavbarPages.MARKETPLACE}
         title={i18n.marketplace}
-        mainUrl={NavbarPagesUrls[NavbarPages.MARKETPLACE.toUpperCase()]}
+        mainUrl={config.get(
+          NavbarPagesUrls[NavbarPages.MARKETPLACE.toUpperCase()]
+        )}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.CREATE}
         title={i18n.create}
-        mainUrl={NavbarPagesUrls[NavbarPages.CREATE.toUpperCase()]}
+        mainUrl={config.get(NavbarPagesUrls[NavbarPages.CREATE.toUpperCase()])}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.EXPLORE}
         title={i18n.explore}
-        mainUrl={NavbarPagesUrls[NavbarPages.EXPLORE.toUpperCase()]}
+        mainUrl={config.get(NavbarPagesUrls[NavbarPages.EXPLORE.toUpperCase()])}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.LEARN}
         title={i18n.learn}
-        mainUrl={NavbarPagesUrls[NavbarPages.LEARN.toUpperCase()]}
+        mainUrl={config.get(NavbarPagesUrls[NavbarPages.LEARN.toUpperCase()])}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.GOVERNANCE}
         title={i18n.governance}
-        mainUrl={NavbarPagesUrls[NavbarPages.GOVERNANCE.toUpperCase()]}
+        mainUrl={config.get(
+          NavbarPagesUrls[NavbarPages.GOVERNANCE.toUpperCase()]
+        )}
       />
     </div>
   )

diff --git a/src/components/Navbar/Navbar.types.ts b/src/components/Navbar/Navbar.types.ts
@@ -13,11 +13,11 @@ export enum NavbarPages {
 }
 
 export enum NavbarPagesUrls {
-  MARKETPLACE = 'https://decentraland.org/marketplace',
-  CREATE = 'https://decentraland.org/create/',
-  EXPLORE = 'https://decentraland.org/events/',
-  LEARN = 'https://docs.decentraland.org/player/',
-  GOVERNANCE = 'https://decentraland.org/governance/'
+  MARKETPLACE = 'MARKETPLACE_URL',
+  CREATE = 'LANDING_CREATORS_URL',
+  EXPLORE = 'EVENTS_URL',
+  LEARN = 'DOCS_ABOUT_URL',
+  GOVERNANCE = 'GOVERNANCE_URL'
 }
 
 export type NavbarMenuI18nProps = Record<NavbarPages, NavbarPages>