feat: change way to generate NavbarPagesUrl

decentraland · Jul 15, 2024 · e9b05ef · e9b05ef
1 parent 62db571
commit e9b05ef
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 15 deletions.
diff --git a/src/components/Navbar/MainMenu/MainMenu.tsx b/src/components/Navbar/MainMenu/MainMenu.tsx
@@ -2,8 +2,9 @@ import React from 'react'
 import classNames from 'classnames'
 
 import { MenuItem } from '../MenuItem/MenuItem'
-import { NavbarPages, NavbarPagesUrl } from '../Navbar.types'
+import { NavbarPages } from '../Navbar.types'
 import { MainMenuProps } from './MainMenu.types'
+import { NavbarPagesUrl } from '../utils'
 
 import './MainMenu.css'
 
@@ -22,31 +23,31 @@ export const MainMenu = (props: MainMenuProps) => {
         {...menuItemProps}
         section={NavbarPages.MARKETPLACE}
         title={i18n.marketplace}
-        mainUrl={NavbarPagesUrl[NavbarPages.MARKETPLACE]}
+        mainUrl={NavbarPagesUrl(NavbarPages.MARKETPLACE)}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.CREATE}
         title={i18n.create}
-        mainUrl={NavbarPagesUrl[NavbarPages.CREATE]}
+        mainUrl={NavbarPagesUrl(NavbarPages.CREATE)}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.EXPLORE}
         title={i18n.explore}
-        mainUrl={NavbarPagesUrl[NavbarPages.EXPLORE]}
+        mainUrl={NavbarPagesUrl(NavbarPages.EXPLORE)}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.LEARN}
         title={i18n.learn}
-        mainUrl={NavbarPagesUrl[NavbarPages.LEARN]}
+        mainUrl={NavbarPagesUrl(NavbarPages.LEARN)}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.GOVERNANCE}
         title={i18n.governance}
-        mainUrl={NavbarPagesUrl[NavbarPages.GOVERNANCE]}
+        mainUrl={NavbarPagesUrl(NavbarPages.GOVERNANCE)}
       />
     </div>
   )

diff --git a/src/components/Navbar/Navbar.types.ts b/src/components/Navbar/Navbar.types.ts
@@ -3,7 +3,6 @@ import {
   ChainSelectorProps,
   ChainSelectori18n
 } from '../ChainSelector/ChainSelector.props'
-import { config } from '../../config'
 
 export enum NavbarPages {
   MARKETPLACE = 'marketplace',
@@ -13,14 +12,6 @@ export enum NavbarPages {
   GOVERNANCE = 'governance'
 }
 
-export const NavbarPagesUrl: Record<NavbarPages, string> = {
-  [NavbarPages.MARKETPLACE]: config.get('MARKETPLACE_URL'),
-  [NavbarPages.CREATE]: config.get('LANDING_CREATORS_URL'),
-  [NavbarPages.EXPLORE]: config.get('EVENTS_URL'),
-  [NavbarPages.LEARN]: config.get('DOCS_ABOUT_URL'),
-  [NavbarPages.GOVERNANCE]: config.get('GOVERNANCE_URL')
-}
-
 export type NavbarMenuI18nProps = Record<NavbarPages, NavbarPages>
 
 export type NavbarSubMenuItemsProps = {

diff --git a/src/components/Navbar/utils.ts b/src/components/Navbar/utils.ts
@@ -0,0 +1,19 @@
+import { config } from '../../config'
+import { NavbarPages } from './Navbar.types'
+
+export const NavbarPagesUrl = (navPage: NavbarPages) => {
+  switch (navPage) {
+    case NavbarPages.MARKETPLACE:
+      return config.get('MARKETPLACE_URL')
+    case NavbarPages.CREATE:
+      return config.get('LANDING_CREATORS_URL')
+    case NavbarPages.EXPLORE:
+      return config.get('EVENTS_URL')
+    case NavbarPages.LEARN:
+      return config.get('DOCS_ABOUT_URL')
+    case NavbarPages.GOVERNANCE:
+      return config.get('GOVERNANCE_URL')
+    default:
+      return ''
+  }
+}