Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: total filtered download #187

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

ArzelaAscoIi
Copy link
Member

Related Issues

Proposed Changes?

  • pass name, content and odata_filters to paginated list to calculate the total filtered files

How did you test it?

  • existing tests

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

Copy link

swarmia bot commented May 5, 2024

Copy link

github-actions bot commented May 5, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  deepset_cloud_sdk/_service
  files_service.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was covered by existing tests - why didn't we catch it before?

@ArzelaAscoIi
Copy link
Member Author

If this was covered by existing tests - why didn't we catch it before?

I was expecting that a test fails and i just quickly fix it. But turns out that there was no unit test for the progress par 🙃 added it

@ArzelaAscoIi ArzelaAscoIi requested a review from wochinge May 6, 2024 07:28
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻

@ArzelaAscoIi ArzelaAscoIi added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit c5881af May 6, 2024
9 checks passed
@ArzelaAscoIi ArzelaAscoIi deleted the fix/totalFilteredDownload branch May 6, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants