Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: name and version flags on create + generates CLI docs #768

Merged
merged 27 commits into from
Jul 9, 2024
Merged

feat: name and version flags on create + generates CLI docs #768

merged 27 commits into from
Jul 9, 2024

Conversation

UncleGedd
Copy link
Collaborator

@UncleGedd UncleGedd commented Jul 8, 2024 •
edited by TristanHoladay
Loading

Description

Adds --name and --version to uds create cmd

Related Issue

Fixes #726
Resolves #745

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

@UncleGedd UncleGedd changed the title feat: name and version flags on create feat: name and version flags on create + generates CLI docs Jul 8, 2024
TristanHoladay
TristanHoladay reviewed Jul 9, 2024
View reviewed changes
hack/test-docs.sh Outdated Show resolved Hide resolved
UncleGedd and others added 2 commits July 9, 2024 13:12
@UncleGedd @TristanHoladay
Update src/test/e2e/bundle_test.go
31d914d 
Co-authored-by: Tristan Holaday <[email protected]>
@UncleGedd @TristanHoladay
Update hack/test-docs.sh
97f5fbf 
Co-authored-by: Tristan Holaday <[email protected]>
@UncleGedd UncleGedd merged commit 98301f2 into main Jul 9, 2024
15 checks passed
@UncleGedd UncleGedd deleted the version-flag branch July 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristanHoladay TristanHoladay TristanHoladay approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy jeff-mccoy is a code owner

@decleaver decleaver Awaiting requested review from decleaver decleaver is a code owner

@mjnagel mjnagel Awaiting requested review from mjnagel mjnagel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Break out CLI commands in docs to make them more readable Set UDS Bundle version during bundle create
3 participants
@UncleGedd @TristanHoladay @decleaver