-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemoveItem is too fast for store - policies.Store.removeItem(p); #463
Comments
New deployment of
|
Just to follow up here, the issue appears to actually be due to attempting a delete on a key that doesn't exist (as is the case on a fresh install). This is a related pepr issue - defenseunicorns/pepr#865 - for now we can just conditionally do the removes based on existence of the keys (as is done in the linked PR). |
## Description Workaround for issue where Pepr store fails to update the store perpetually if a `removeItem` is called on a key that does not exist. FIxes #463 ## Related Issue Fixes #463 <!-- or --> Relates to defenseunicorns/pepr#865 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed
## Description Workaround for issue where Pepr store fails to update the store perpetually if a `removeItem` is called on a key that does not exist. FIxes #463 ## Related Issue Fixes #463 <!-- or --> Relates to defenseunicorns/pepr#865 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed
Environment
uds-core/pepr.ts
Line 35 in 7cf9c4c
Using the store in an atomic way is creating 422 errors when removing items. We should consider
Store.clear()
or something less transactionalreported by @zack-is-cool who also said everything seemed to be working fine but was noticing the
422
in the logs.The text was updated successfully, but these errors were encountered: