Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip full testing for documentation only changes #589

Closed
mjnagel opened this issue Jul 18, 2024 · 0 comments · Fixed by #700
Closed

Skip full testing for documentation only changes #589

mjnagel opened this issue Jul 18, 2024 · 0 comments · Fixed by #700
Assignees
@UnicornChance
Labels
ci Issues pertaining to CI / Pipelines / Testing documentation Improvements or additions to documentation enhancement New feature or request
Milestone
0.27.0

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Jul 18, 2024

Feature Request

When a PR is created with documentation only changes - only linting/docs validation should run. In order to ensure that the required PR checks still pass we may need to build out a "docs shim" to run workflows with the same name (see this as an example).
@mjnagel mjnagel added documentation Improvements or additions to documentation enhancement New feature or request ci Issues pertaining to CI / Pipelines / Testing labels Jul 18, 2024
@mjnagel mjnagel mentioned this issue Aug 1, 2024
Closed
@mjnagel mjnagel added this to the 0.26.0 milestone Aug 5, 2024
@UnicornChance UnicornChance self-assigned this Aug 21, 2024
@mjnagel mjnagel modified the milestones: 0.26.0, 0.27.0 Aug 21, 2024
@UnicornChance UnicornChance mentioned this issue Aug 26, 2024
Merged
5 tasks
@UnicornChance UnicornChance linked a pull request Aug 26, 2024 that will close this issue
fix: update ci workflows for docs shim #700
Merged
5 tasks
mjnagel pushed a commit that referenced this issue Aug 29, 2024
@UnicornChance
fix: update ci workflows for docs shim (#700)
5d89254 
## Description
We don't want to run CI jobs on documentation only changes.

Testing was done in a personal repo.

## Related Issue

Fixes #589 
Fixes #628 

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UnicornChance UnicornChance

Labels
ci Issues pertaining to CI / Pipelines / Testing documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

fix: update ci workflows for docs shim defenseunicorns/uds-core
2 participants
@mjnagel @UnicornChance