Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initial commit for loki updates #449

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

fix: initial commit for loki updates #449

wants to merge 38 commits into from

Conversation

UnicornChance
Copy link
Contributor

Description

Updates for bringing in loki renovate updates

Related Issue

Fixes #308

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@UnicornChance UnicornChance requested a review from a team May 30, 2024 20:41
@UnicornChance UnicornChance marked this pull request as ready for review June 3, 2024 13:34
mjnagel
mjnagel reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't fully deployed yet but wanted to get these two comments out there.

src/loki/values/values.yaml Outdated Show resolved Hide resolved
src/loki/values/values.yaml Outdated Show resolved Hide resolved
mjnagel
mjnagel reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably also want to switch over to Secret for this value - https://github.com/grafana/loki/blob/main/production/helm/loki/values.yaml#L112

@UnicornChance UnicornChance self-assigned this Jul 3, 2024
mjnagel
mjnagel reviewed Aug 6, 2024
View reviewed changes
src/pepr/loki/index.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjnagel mjnagel mjnagel left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@UnicornChance UnicornChance

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@UnicornChance @mjnagel