Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gitlab SSO implementation from chart to secret templating #90

Closed
Tracked by #12
Racer159 opened this issue Mar 25, 2024 · 1 comment · Fixed by #111
Closed
Tracked by #12

Update Gitlab SSO implementation from chart to secret templating #90

Racer159 opened this issue Mar 25, 2024 · 1 comment · Fixed by #111
Assignees
@Racer159
Labels
tech-debt 💳

Comments

@Racer159
Copy link
Contributor

Describe what should be investigated or refactored

We need to update the SSO implementation to use the new secret templating abilities in uds-core.

Links to any relevant code

defenseunicorns/uds-core#263
@oates oates mentioned this issue Mar 26, 2024
Closed
@oates oates changed the title Update SSO implementation from chart to secret templating Update Gitlab SSO implementation from chart to secret templating Apr 1, 2024
@oates
Copy link
Contributor

oates commented Apr 1, 2024

From @zachariahmiller , "the double chart thing should be ripped out"

@Racer159 Racer159 self-assigned this Apr 17, 2024
@Racer159 Racer159 mentioned this issue Apr 18, 2024
Merged
5 tasks
Racer159 added a commit that referenced this issue Apr 19, 2024
@Racer159
chore: switch to new SSO secret template (#111)
acf28bc 
## Description

This implements the new secret templating for GitLab

## Related Issue

Fixes #90 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Racer159 Racer159

Labels
tech-debt 💳
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: switch to new SSO secret template defenseunicorns/uds-package-gitlab
2 participants
@Racer159 @oates