-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure monitoring #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is ready for review but just want to throw this out there for discussion... Example implementation using pepr 5 lines of yaml per monitor:
Example implementation using the gitlab charts service monitors: ~5 lines in one file (there is a global disable for monitors and metrics true may be needed i dont recall so maybe more like 2 lines):
and 8 in another (netpol isnt generated on mutation):
😭 |
ericwyles
approved these changes
May 3, 2024
zachariahmiller
pushed a commit
that referenced
this pull request
May 7, 2024
🤖 I have created a release *beep* *boop* --- ## [16.11.1-uds.1](v16.11.1-uds.0...v16.11.1-uds.1) (2024-05-07) ### Features * configure monitoring ([#117](#117)) ([423687d](423687d)) ### Miscellaneous * add netpol template for runner sandbox ([#125](#125)) ([c5ad463](c5ad463)) * **deps:** update gitlab support dependencies ([#114](#114)) ([3a3a56b](3a3a56b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled service and pod monitors in gitlab. For running on k3d-slim-dev in ci/local we dont have to update anything as the gitlab chart checks for the monitoring capabilities presence to deploy the service monitor templates.
Depends on uds-core 0.21.0.
Note: the pepr capability to mutate the service monitors but not pod monitors so we will need to request that feature or PR uds-core to add it. Adding the config for the pod monitor does no break anything.
As this wont get tested in CI in this repo (we should consider the "on-release" test that will exist soon to deploy a full cluster) I will provide visual proof in the comments. This requires no changes to the end user to enable.
Related Issue
Fixes #
116
Relates to #
Type of change
Checklist before merging