feat(metrics): building blocks for postgres exporter #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwh85
changed the title
rwh85
changed the title
zachariahmiller
requested changes
Jul 18, 2024
… the perrauth exception
… the perrauth exception
|
@Racer159 @zachariahmiller - Thanks for the support on this. I think I've got us to a better place with all initial issues resolved. Noting that the sidecar config is now in the more specific values files as it seems helm isn't able to merge the values in that array so I'm only getting the content of the values file with most precedence. Please let me know if there is anything else you'd like to see here. |
zachariahmiller
previously requested changes
Jul 24, 2024
Racer159
reviewed
Jul 25, 2024
Co-authored-by: Wayne Starr <[email protected]>
Racer159
reviewed
Jul 30, 2024
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
zachariahmiller
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
Racer159
added a commit
that referenced
this pull request
Jul 31, 2024
## Description This adds the Made for UDS badge now that monitoring is in as of #53 ## Related Issue Fixes #52 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [X] Other (security config, docs update, etc) ## Checklist before merging - [X] Test, docs, adr added or updated as needed - [X] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-package-postgres-operator/blob/main/CONTRIBUTING.md#developer-workflow) followed
Racer159
pushed a commit
that referenced
this pull request
Jul 31, 2024
🤖 I have created a release *beep* *boop* --- ## [1.12.2-uds.2](v1.12.2-uds.1...v1.12.2-uds.2) (2024-07-31) ### Features * **metrics:** building blocks for postgres exporter ([#53](#53)) ([c2a47bc](c2a47bc)) ### Miscellaneous * add `Made for UDS` badge ([#57](#57)) ([2aa0328](2aa0328)) * **deps:** update postgres support dependencies ([#50](#50)) ([18c6c03](18c6c03)) * **deps:** update postgres support dependencies ([#56](#56)) ([a79c9c6](a79c9c6)) * **deps:** update support-deps to v3.25.15 ([#55](#55)) ([84d4c33](84d4c33)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the package by introducing a metrics endpoint to the PostgreSQL cluster pods. The implementation involves adding a sidecar to the pods, which exposes a port for Prometheus to scrape using a configured PodMonitor.
The changes avoid using the package CR to expose the metrics endpoint due to its complexity, particularly the need to exempt from uds/skip-mutate: "true" and to configure the PeerAuthentication CR to carve out a permissive mTLS port for the PodMonitor.
Monitoring can be enabled, but defaults to false.
Related Issue
Relates to #51
Type of change
Checklist before merging