Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nfs and smartquota info #89

Conversation

Kritika-Bhateja-03
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

plugins/modules/info.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Bhavneet-Sharma Bhavneet-Sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate module files with Andersson's script as well.

plugins/modules/nfs.py Show resolved Hide resolved
plugins/modules/nfs.py Outdated Show resolved Hide resolved
@sachin-apa
Copy link
Collaborator

run e2e

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 37.41935% with 97 lines in your changes missing coverage. Please review.

Project coverage is 81.96%. Comparing base (dda4a2e) to head (b0d09ea).
Report is 2 commits behind head on main.

Files Patch % Lines
plugins/modules/filesystem.py 30.10% 50 Missing and 15 partials ⚠️
plugins/modules/info.py 13.63% 18 Missing and 1 partial ⚠️
plugins/modules/nfs.py 58.82% 2 Missing and 5 partials ⚠️
plugins/modules/smartquota.py 57.14% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   82.32%   81.96%   -0.37%     
==========================================
  Files         116      116              
  Lines       12617    12668      +51     
  Branches     1860     1881      +21     
==========================================
- Hits        10387    10383       -4     
- Misses       1659     1707      +48     
- Partials      571      578       +7     
Flag Coverage Δ
units 81.96% <37.41%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kritika-Bhateja-03
Copy link
Collaborator Author

image
UT coverage for smartquota

plugins/modules/filesystem.py Show resolved Hide resolved
plugins/modules/info.py Outdated Show resolved Hide resolved
sachin-apa
sachin-apa previously approved these changes Jul 24, 2024
tests/unit/plugins/modules/test_info.py Outdated Show resolved Hide resolved
sachin-apa
sachin-apa previously approved these changes Jul 24, 2024
trisha-dell
trisha-dell previously approved these changes Jul 24, 2024
@trisha-dell trisha-dell dismissed stale reviews from meenakshidembi691, sachin-apa, and themself via 2ff9fca July 24, 2024 11:02
sachin-apa
sachin-apa previously approved these changes Jul 24, 2024
@trisha-dell trisha-dell merged commit a7da20f into dell:main Jul 24, 2024
25 checks passed
@Kritika-Bhateja-03 Kritika-Bhateja-03 deleted the usr/Kriitka-Bhateja-03/ANSISILON-1939_update_info_module branch July 24, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants