Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples of using the CLI #107

Merged
merged 16 commits into from
Aug 8, 2022
Merged

Add more examples of using the CLI #107

merged 16 commits into from
Aug 8, 2022

Conversation

Chuxel
Copy link
Member

@Chuxel Chuxel commented Aug 5, 2022

This PR adds in scripts and a README that illustrates how to use the CLI to:

  • Inject tools for use inside a development container
  • Use a dev container as your CI build environment to build an application (even if it is not deployed as a container)
  • Build a container image from a devcontainer.json file that includes dev container features

@Chuxel Chuxel requested a review from a team as a code owner August 5, 2022 22:11
@Chuxel Chuxel requested a review from bamurtaugh August 5, 2022 22:15
@Chuxel
Copy link
Member Author

Chuxel commented Aug 5, 2022

BTW - I raised several issues while putting this together, which seems to indicate it could be adapted to regression tests. I did not do that with this PR.

Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to see, and I think it'll really help users! Left a few comments and suggestions.

README.md Outdated Show resolved Hide resolved
example-usage/README.md Outdated Show resolved Hide resolved
example-usage/README.md Outdated Show resolved Hide resolved
example-usage/README.md Outdated Show resolved Hide resolved
example-usage/README.md Outdated Show resolved Hide resolved
example-usage/README.md Outdated Show resolved Hide resolved
example-usage/README.md Outdated Show resolved Hide resolved
example-usage/README.md Outdated Show resolved Hide resolved
example-usage/README.md Outdated Show resolved Hide resolved
example-usage/README.md Outdated Show resolved Hide resolved
Chuxel and others added 10 commits August 5, 2022 17:38
Co-authored-by: Brigit Murtaugh <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
jkeech
jkeech previously approved these changes Aug 5, 2022
Copy link
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these examples! I think it will be really helpful for people to get started using the CLI. ✨

I left a couple small suggestions, but otherwise looks good to me. I agree that we could turn some scenarios like these into regression tests. That would be a great improvement for a future PR.

jkeech
jkeech previously approved these changes Aug 5, 2022
chrmarti
chrmarti previously approved these changes Aug 8, 2022
example-usage/README.md Outdated Show resolved Hide resolved
example-usage/README.md Show resolved Hide resolved
@Chuxel Chuxel merged commit fb94533 into main Aug 8, 2022
@Chuxel Chuxel deleted the clantz/example-usage branch August 8, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants