Incrementally copy features near the layer they're installed #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and avoid invalidating the entire build context when any feature changes
|
cc: @chrmarti |
4 tasks
|
It seems after changing dockerfile, Features installation is not using cache anymore. does this PR also fix that ? |
|
Very awesome! Just validated this continues to work as expected when rebased against main. Validated that changing the contents of the final Feature (in this case a local Feature) preserves all previously cached layers, and the change is picked up 👍
|
joshspicer
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incrementally copies each feature's contents near the layer they're installed, so rebuilds of a devcontainer take full advantage of the build cache.
To illustrate the behavior I built a devcontainer, edited the source of the last feature in the image, then rebuilt it again. With the public
devcontainerCLI, the image rebuilds all features even though only the last one changed. With this PR, the second build used the layer cache and started from the layer of the changed feature.1m31.803s)1m29.621s)1m27.219s)0m32.794s🔥 🚀 🔥 🚀 🔥 🚀)Fixes #291 and #313