Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --workspace-folder optional, default to ".". Fixes #29 #424

Closed
wants to merge 1 commit into from
Closed

Make --workspace-folder optional, default to ".". Fixes #29 #424

wants to merge 1 commit into from

Conversation

alexec
Copy link

@alexec alexec commented Feb 27, 2023 •
edited
Loading

Fixes #29

I don't know how to test this, and ironically I created this PR in Codespaces, but I cannot run tests:

image

Please advise.

@alexec alexec marked this pull request as ready for review February 27, 2023 15:48
@alexec alexec requested a review from a team as a code owner February 27, 2023 15:48
@MunsMan
Copy link

MunsMan commented Feb 27, 2023 •
edited
Loading

Isn't that similar to #332?

Should we check if a .devcontainer file exists in the current directory?

I just added some basis checking and opened PR #425

@alexec
Copy link
Author

alexec commented Feb 27, 2023

Exactly the same, to the byte. I don't think the check needs to be smart.

@alexec alexec closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why Is --workspace-folder Required. Can we default to $PWD?
2 participants
@alexec @MunsMan