Don't add source file/line number info to pot for stringdumps (#91)

dfint · Jun 27, 2024 · 74397ea · 74397ea
1 parent bd0fedd
commit 74397ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/df_translation_toolkit/create_pot/from_string_dump.py b/df_translation_toolkit/create_pot/from_string_dump.py
@@ -1,6 +1,4 @@
-from pathlib import Path
-
-import typer
+import typer
 
 from df_translation_toolkit.utils.df_ignore_string_rules import all_ignore_rules, dont_ignore
 from df_translation_toolkit.utils.po_utils import TranslationItem, save_pot
@@ -13,10 +11,9 @@ def main(
 ):
     template = (line.rstrip("\n") for line in source_file)
     ignore_rules = dont_ignore if no_ignore else all_ignore_rules
-    file_name = Path(source_file.name).name
     filtered_lines = (
-        TranslationItem(text=line, source_file=file_name, line_number=line_number)
-        for line_number, line in enumerate(template, 1)
+        TranslationItem(text=line)
+        for line in template
         if not ignore_rules(line)
     )
     save_pot(destination_file, filtered_lines)

diff --git a/df_translation_toolkit/utils/po_utils.py b/df_translation_toolkit/utils/po_utils.py
@@ -41,7 +41,8 @@ def save_pot(po_file: BinaryIO, template: Iterable[TranslationItem]):
     catalog = Catalog()
 
     for item in template:
-        catalog.add(item.text, context=item.context, locations=[(item.source_file, item.line_number)])
+        locations = [(item.source_file, item.line_number)] if item.source_file else ()
+        catalog.add(item.text, context=item.context, locations=locations)
 
     po_file.write(_default_header + b"\n\n")
     write_po(po_file, catalog, omit_header=True)