Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separation of constructor parameters #20

Closed
dusta opened this issue Dec 16, 2018 · 0 comments
Closed

Separation of constructor parameters #20

dusta opened this issue Dec 16, 2018 · 0 comments

Comments

@dusta
Copy link
Member

dusta commented Dec 16, 2018

Before

 public function __construct($config, $image, $default = false, $storage)

After

public function __construct($driver, $config)
public function setImage($image, $default = false)
@dusta dusta pinned this issue Dec 16, 2018
@dusta dusta unpinned this issue Dec 16, 2018
@dusta dusta closed this as completed in aeee780 Dec 16, 2018
dusta added a commit that referenced this issue Dec 16, 2018
@dusta
Resolved #20, Separation of constructor parameters
97346a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dusta