-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vignette on nonequi joins #20
base: master
Are you sure you want to change the base?
Conversation
Current coverage is 84.65% (diff: 100%)@@ master #20 diff @@
==========================================
Files 7 9 +2
Lines 327 443 +116
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 273 375 +102
- Misses 54 68 +14
Partials 0 0
|
Wow! I really didn't realize it was this simple (I've tried non-equi joins before, but with solutions that weren't as concise). Before merging, I wonder if there's a way to turn this into a |
Thanks for taking a look, the credit goes to the author of this SO answer. For a specific function, do you mean something that might work like this?
|
I'm looking at this again while planning a CRAN release. I'm starting to think if we do encourage One example, of joining two tables of size 1000 each, indicates data.table can be ~100X faster:
Results on my machine:
I don't mind taking on data.table as a dependency (probably IMPORTS, though could be SUGGESTS with a check at the start of the function) since there are likely other opportunities to use it to speed up functions. |
That's great to know about the speed up from data.table. I'll have a go at making an |
I've got most of this implemented now, so I'll go ahead with finishing it! |
Sounds good, thanks! |
Did this make it into the current CRAN version? I'm not sure that I can find it in the docs. Thanks! |
Unfortunately not yet- I think I'm going to submit a CRAN version today (there are some long-running bug fixes and new features) and then get back to work on this for the next version. I'd rather have it all complete though, and again I really do appreciate the vignette! |
Righto, thanks for the update. I'm looking forward to the next CRAN release! |
What happened to this update :D |
Here is short vignette in response to your call, showing a use that seems in demand, but not easily available elsewhere, cf. tidyverse/dplyr#557 and http://stackoverflow.com/q/41132081/1036500. Let me know what you think!