Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidyverse update #58

Merged
merged 10 commits into from
Aug 5, 2019
Merged

Tidyverse update #58

merged 10 commits into from
Aug 5, 2019

Conversation

jennybc
Copy link
Contributor

@jennybc jennybc commented Aug 5, 2019

This clears a big whack of warnings about use of deprecated functions and generally gets more current with CRAN dplyr and tidyr and some good practices.

Seems most expedient way to get code that works with CRAN tidyr and the dev version that will become v1.0.0
dplyr::rename_at() gained the ability to cope gracefully with an empty `.vars` in dplyr 0.8.1 (2019-05-14).
CRAN will add this anyway and, when managed manually, it's inevitable you will goof it up / forget to update it.
@dgrtwo
Copy link
Owner

dgrtwo commented Aug 5, 2019

I've learned a lot from reading this, thank you! (Not using Date is a very good recommendation).

I'll merge this than the IRanges one, we'll see how AppVeyor looks then 👍

@dgrtwo dgrtwo merged commit 16e7597 into dgrtwo:master Aug 5, 2019
@jennybc
Copy link
Contributor Author

jennybc commented Aug 5, 2019

Things are looking up! FYI "squash and merge" is good for PRs like my meandering one, trying to fix the AppVeyor config #59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants