Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow 5 #67

Merged
merged 171 commits into from
Nov 5, 2018
Merged

Workflow 5 #67

merged 171 commits into from
Nov 5, 2018

Conversation

dhilt
Copy link
Owner

@dhilt dhilt commented Oct 2, 2018 •
edited
Loading

UIScroll Workflow Engine v5

Core changes

  1. The next fetch does not depend on the previous one. This means that all intermediate Datasource.get calls that aren't needed to fill the visible part of the viewport will be skipped.
  2. Scroll becomes a Process and now its handling is much more clear in terms of the Workflow.
  3. Clip process is immediate now (reduced render cycles).
  4. Introduced min/maxIndex settings to limit the Datasource and provide consistent scroll bar parameters.
  5. Introduced itemSize setting to optimize first fetch or/and provide an information about average item size.
  6. Correct handling the inertia scroll events. It does not affect the UX anymore.

TODO

  • all core changes
  • logger
  • basic load/scroll tests
  • cases when one of minIndex/maxIndex is absent
  • cases when itemSize is not present
  • eof/bof spec
  • different items sizes spec
  • entire window viewport case
  • fix scroll position correction during inertia
  • update documentation
  • update demo app
  • deploy to Heroku (https://ngx-ui-scroll.herokuapp.com/)
  • datasource demo page

dhilt added 30 commits June 24, 2018 15:09
@dhilt
min/max indexes and average size
88db8f0
@dhilt
cache items after render, keep size
7c67795
@dhilt
min/max indexes on Buffer
176d258
@dhilt
do not build
1366a0e
@dhilt
do not build
3754e59
@dhilt
Merge branch 'master' of github.com:dhilt/ngx-ui-scroll into workflow-5
0730edd
@dhilt
min/maxIndex, itemSize settings
39aad65
@dhilt
prepare scroller hierarchy to non-directional fetching
593e35e
@dhilt
prepare processes to non-directional fetching
8a349f3
@dhilt
initial load does work
5d778e5
@dhilt
Merge branch 'first-visible' into workflow-5
a688bd9 
# Conflicts:
#	demo/app/samples/test.component.ts
#	src/component/classes/item.ts
#	src/component/classes/state.ts
#	src/component/classes/viewport.ts
@dhilt
switch preFetch from items indexes to items positions
1a34d06
@dhilt
preFetch cleanup
a9164bb
@dhilt
Merge branch 'master' into workflow-5
aef050d 
# Conflicts:
#	src/component/classes/state.ts
#	src/component/scroller.ts
@dhilt
workflow-5: clip before fetch
44bf160
@dhilt
unidirectional clip
6228911
@dhilt
forward scroll does work
70915a2
@dhilt
fix forward padding size when the viewport is not filled enough
70cb0f6
@dhilt
geometry fixes
2d370ff
@dhilt
backward scroll does work (fold case)
7a02d29
@dhilt
eof/bof refactoring
53ac5d7
@dhilt
explicit bwd items
3b97330
@dhilt
Merge branch 'master' into workflow-5
b8dc683 
# Conflicts:
#	src/component/classes/state.ts
@dhilt
positive scroll up does work
1de86c1
@dhilt
negative size approach
f896b90
@dhilt
reload index fix
1de0b6e
@dhilt
protect buffer reload
b97fbc1
@dhilt
test demo updates (delay input)
9f5058a
@dhilt
clip padding
98c5a37
@dhilt
inertialScrollDelay and logTime dev settings
9f36315
@dhilt dhilt temporarily deployed to ngx-ui-scroll October 27, 2018 18:03 Inactive
@dhilt dhilt temporarily deployed to ngx-ui-scroll October 27, 2018 21:52 Inactive
@dhilt dhilt temporarily deployed to ngx-ui-scroll October 28, 2018 01:07 Inactive
@dhilt dhilt temporarily deployed to ngx-ui-scroll October 28, 2018 23:44 Inactive
@dhilt dhilt mentioned this pull request Nov 1, 2018
Open
@dhilt dhilt merged commit 5f9693d into master Nov 5, 2018
@dhilt dhilt deleted the workflow-5 branch December 27, 2018 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhilt @dyuvzhenko