Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #584 show albums and tracks when filtering for genres via search text #596

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

dermeck
Copy link
Contributor

@dermeck dermeck commented Mar 24, 2024

This is split into two commits because I'm not sure if the second commit is "too much" and should be reverted.

the first one is the actual fix:

  • adds genres field to album model
  • considers genres field of track/album when the respective filter-pipe is used

the second one is a rafactoring:

  • first collects the relevant text and only calls the searchService once, which (subjectively) also makes the test a bit easier

@digimezzo
Copy link
Owner

Thanks for this PR! And sorry for the delay in reviewing this. I'll review it this week.

@dermeck
Copy link
Contributor Author

dermeck commented Apr 8, 2024

No worries - I'm aware that this is a side project :) .

@digimezzo
Copy link
Owner

@dermeck Thanks again for this PR. The fix looks great! I'm merging it.

@digimezzo digimezzo merged commit eb49a34 into digimezzo:master Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants