all: Allow to build with CLANG in cl mode

dimhotepus · Jun 27, 2024 · d640714 · d640714
1 parent 57327c7
commit d640714
Show file tree

Hide file tree

Showing 12 changed files with 6 additions and 6 deletions.
diff --git a/bink_media_player/main.cc b/bink_media_player/main.cc
@@ -71,7 +71,7 @@ bool MoveToMainDisplayCenter(_In_ HWND window,
  */
 void ToggleFullscreenWindow(_In_ HWND window, _In_ DWORD default_window_style) {
   static WINDOWPLACEMENT previous_window_placement{
-      sizeof(previous_window_placement), 0U, 0U};
+      sizeof(previous_window_placement), 0U, 0U, {}, {}, {}};
 
   BINK_DCHECK(!!window);
 
@@ -249,7 +249,7 @@ LRESULT WINAPI WindowProc(HWND window, UINT message, WPARAM wParam,
  */
 [[nodiscard]] HWND CreateBinkWindow(_In_ HINSTANCE instance,
                                     _In_z_ LPCSTR cmd_line) noexcept {
-  WNDCLASS wc = {0};
+  WNDCLASS wc = {};
   // Handle resizes in WM_PAINT.
   wc.style = CS_OWNDC | CS_VREDRAW | CS_HREDRAW;
   wc.lpfnWndProc = WindowProc;
@@ -341,7 +341,7 @@ int WINAPI WinMain(_In_ HINSTANCE instance, _In_opt_ HINSTANCE,
       std::optional{std::move(*bink_media_player_result)};
   bink_media_player_host.swap(maybe_bink_media_player);
 
-  bink::BinkMediaInfo media_info = {0};
+  bink::BinkMediaInfo media_info = {};
   if (!bink_media_player_host->GetMediaInfo(media_info)) {
     ::MessageBoxA(window, "Unable to get media info.",
                   "Bink Media Player - Media Open Error", MB_OK | MB_ICONSTOP);

diff --git a/bink_media_player/scoped_timer_resolution.h b/bink_media_player/scoped_timer_resolution.h
@@ -109,7 +109,7 @@ class ScopedTimerResolution {
   unsigned error_code_;
 
 #ifdef _WIN64
-  std::byte pad_[sizeof(char *) - sizeof(error_code_)];  //-V730_NOINIT
+  [[maybe_unused]] std::byte pad_[sizeof(char *) - sizeof(error_code_)];  //-V730_NOINIT
 #endif
 
   /**

diff --git a/binkmp/bink_media_player.h b/binkmp/bink_media_player.h
@@ -163,7 +163,7 @@ class BinkMediaPlayer : public IBinkMediaPlayer {
    * @param height New height.
    * @return true on success, false on failure.
    */
-  bool SetWindowScale(unsigned width, unsigned height) const noexcept {
+  bool SetWindowScale(unsigned width, unsigned height) const noexcept override {
     const auto [new_width, new_height] = FindClosestScale(width, height);
     return bink_buffer_.SetWindowScale(new_width, new_height);
   }

diff --git a/binkmp/ibink_media_player.cc b/binkmp/ibink_media_player.cc
@@ -6,6 +6,6 @@
 
 namespace bink {
 
-IBinkMediaPlayer::~IBinkMediaPlayer() {}
+IBinkMediaPlayer::~IBinkMediaPlayer() noexcept {}
 
 }  // namespace bink
diff --git a/binkw/binkw.cc b/binkw/binkw.cc
diff --git a/binkw/dllmain.cc b/binkw/dllmain.cc
diff --git a/binkw/stdafx.cc b/binkw/stdafx.cc
diff --git a/binkw/stdafx.h b/binkw/stdafx.h
diff --git a/binkw/targetver.h b/binkw/targetver.h
diff --git a/mss/dllmain.cc b/mss/dllmain.cc
diff --git a/mss/mss.cc b/mss/mss.cc
diff --git a/mss/targetver.h b/mss/targetver.h