-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic description #14
Comments
Yes, retrieve some description from the the meta-data looks like a good idea. Perhaps adding a delete button on the description field would be helpful when the provided text is broken or unwanted. About the tags, I was thinking of a good way of handling them : would the choice of tags be based on the shared url, on the sharing app or on key words in the description ? Maybe a mix of theses. It would also need a little rework of the tags field to delete them easily, indeed adding such automation would create a significant amount of unwanted tags. The problem is that each user has its own view of what a good tag is, and I would not be the one choosing for them. |
there's a lengthy thread over at shaarli/Shaarli#322 description makes sense to me (https://github.com/mro/ShaarliOS), tags rather don't. |
Solve #14 I have found a bug : without dialog the page description would not load, have not managed to reproduce it twice...
Could you have a look at : https://github.com/dimtion/Shaarlier/releases/tag/v1.3.0-alpha Please tell me if you have remarks or if you find any bug. |
It works well! But more websites could be supported (because they don't use the classic meta description) if you add:
(plus, the |
Thanks for the feedback, I'll add them for the next release. |
see also at shaarli/Shaarli#322 (comment) |
Thanks @mro for the reminder (I have probably over read your comment...) In shaarli/Shaarli#322 they don't mention |
@dimtion I think twitter must be the last because it's limited in every case or there are hashtags inside. I would say : But maybe I'm wrong! |
Yes you are right, but as @mro mentioned in shaarli/Shaarli#322 (comment) |
It could be great to have an automatic description of the link by reading the content of the meta "description".
Just like the title, but for the description.
And, maybe, tags?
The text was updated successfully, but these errors were encountered: