Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic description #14

Closed
NerosTie opened this issue Aug 16, 2015 · 9 comments
Closed

Add automatic description #14

NerosTie opened this issue Aug 16, 2015 · 9 comments
Milestone

Comments

@NerosTie
Copy link

It could be great to have an automatic description of the link by reading the content of the meta "description".
Just like the title, but for the description.
And, maybe, tags?

@dimtion
Copy link
Owner

dimtion commented Aug 25, 2015

Yes, retrieve some description from the the meta-data looks like a good idea. Perhaps adding a delete button on the description field would be helpful when the provided text is broken or unwanted.

About the tags, I was thinking of a good way of handling them : would the choice of tags be based on the shared url, on the sharing app or on key words in the description ? Maybe a mix of theses. It would also need a little rework of the tags field to delete them easily, indeed adding such automation would create a significant amount of unwanted tags. The problem is that each user has its own view of what a good tag is, and I would not be the one choosing for them.

@mro
Copy link

mro commented Aug 25, 2015

there's a lengthy thread over at shaarli/Shaarli#322

description makes sense to me (https://github.com/mro/ShaarliOS), tags rather don't.

dimtion added a commit that referenced this issue Nov 22, 2015
Solve #14
I have found a bug : without dialog the page description would not load, have not managed to reproduce it twice...
@dimtion dimtion added this to the v1.3.0 milestone Nov 22, 2015
@dimtion
Copy link
Owner

dimtion commented Nov 22, 2015

Could you have a look at : https://github.com/dimtion/Shaarlier/releases/tag/v1.3.0-alpha

Please tell me if you have remarks or if you find any bug.

@NerosTie
Copy link
Author

It works well!

But more websites could be supported (because they don't use the classic meta description) if you add:

<meta property="og:description" content="" />
<meta name="twitter:description" content="" />

(plus, the Settings menu in the app, between Share a link and Open my Shaarli, is useless)

@dimtion
Copy link
Owner

dimtion commented Nov 23, 2015

Thanks for the feedback, I'll add them for the next release.

@mro
Copy link

mro commented Nov 23, 2015

see also at shaarli/Shaarli#322 (comment)

@dimtion
Copy link
Owner

dimtion commented Nov 23, 2015

Thanks @mro for the reminder (I have probably over read your comment...)

In shaarli/Shaarli#322 they don't mention twitter:description meta tag, what priority should be choose ? What about for example og:description > twitter:description > description) ?

@NerosTie
Copy link
Author

@dimtion I think twitter must be the last because it's limited in every case or there are hashtags inside.

I would say : description > og:description > twitter:description (og=opengraph=facebook)

But maybe I'm wrong!

@dimtion
Copy link
Owner

dimtion commented Nov 23, 2015

Yes you are right, but as @mro mentioned in shaarli/Shaarli#322 (comment) og:description should probably be first.

@dimtion dimtion closed this as completed Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants