Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shaarli2mastodon #38

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Add support for shaarli2mastodon #38

merged 1 commit into from
Apr 14, 2019

Conversation

angristan
Copy link
Contributor

I opened #34 a year ago and I still use Shaarli and Mastodon every day.

I recently started learning Java at school as well as a little bit of Android development.

Since I am a bit more comfortable with the language and the structure of Android apps, I tried to fix this issue myself!

Overall it's a copy/paste of the shaarli2twitter feature. I was able to test it on my phone on Pie and can confirm it's perfectly working! 🎉

I hope I did not make hideous stuff and that you will accept my PR 😄

@angristan
Copy link
Contributor Author

PS: Android Studio made all these changes to app/app.iml when bulding the app. I don't know if I should have committed them or not.

@angristan
Copy link
Contributor Author

This is how it looks:

Screenshot_20190413-003935_30
Screenshot_20190413-003945_2_30

@dimtion dimtion added this to the 1.6.0 milestone Apr 13, 2019
@dimtion
Copy link
Owner

dimtion commented Apr 13, 2019

First of all, I would like to give you a big shout-out for this pull request. Since I don't have a Mastodon account, I did not take the time to fix this issue that is awaited by a lot of people.

I have read the PR, it looks good to me, I'll try to test and merge it if I have more time tomorrow.

Thanks again!

@dimtion
Copy link
Owner

dimtion commented Apr 13, 2019

Oh, yeah I have one question: is "toot" the equivalent to "tweet" in Mastodon vocab?

@angristan
Copy link
Contributor Author

Awesome! Yes, a toot is the equivalent of a tweet.

Screenshot 2019-04-13 at 14 44 42

@dimtion dimtion merged commit 97fb5a8 into dimtion:master Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants