Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sniffer: fix mangled lines on stdout output #62

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

maxmouchet
Copy link
Member

@maxmouchet maxmouchet commented Jan 6, 2024

Newlines were fixed in #61 but we're still getting bad lines:

1704573826,1,::ffff:132.227.123.8,::ffff:37.61.226.8,24000,0,8,1,::ffff:62.40.98.238,1,11,0,241,172,"[(14716,0,0,11704573826,1,::ffff:132.227.123.8,::ffff:37.23.143.233,24000,0,8,1,::ffff:62.40.98.238,1,11,0,248,168,"[(62839,0,1,1)]",92,1

std::ios::sync_with_stdio(false); seems to be the culprit.

@maxmouchet maxmouchet changed the title sniffer: fix mangled newlines on stdout output (attempt #2) sniffer: fix mangled lines on stdout output Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4764ae4) 80.37% compared to head (d96956a) 80.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   80.37%   80.37%           
=======================================
  Files          23       23           
  Lines        1228     1228           
  Branches      712      712           
=======================================
  Hits          987      987           
  Misses        115      115           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxmouchet maxmouchet force-pushed the max/fix-mangled-lines branch 3 times, most recently from aed264c to cb3d588 Compare January 6, 2024 21:57
@maxmouchet maxmouchet merged commit cc43fc8 into main Jan 6, 2024
8 checks passed
@maxmouchet maxmouchet deleted the max/fix-mangled-lines branch January 6, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant