build: replace poetry with setup.py #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmouchet
force-pushed
the
max/fix-poetry-build
branch
2 times, most recently
from
e4cee70
to
6492f7f
Compare
maxmouchet
changed the title
maxmouchet
force-pushed
the
max/fix-poetry-build
branch
2 times, most recently
from
976755e
to
ce5b205
Compare
maxmouchet
force-pushed
the
max/fix-poetry-build
branch
from
ce5b205
to
5cd9f59
Compare
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
maxmouchet
added a commit
that referenced
this pull request
Oct 27, 2023
This reverts commit e38b172.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
poetry installon macOS (and potentially other platforms) fails with the following error:As @SaiedKazemi pointed out, removing the following section from the
pyproject.tomlfixes the issue:However poetry now seems to fail to package the native extensions built with Cython.
Let's get rid of poetry, Cython extensions have never really been supported and we already had to fix similar issues in the past.