Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pycaracal with caracal #155

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Replace pycaracal with caracal #155

merged 1 commit into from
Oct 27, 2023

Conversation

maxmouchet
Copy link
Member

@maxmouchet maxmouchet commented Oct 27, 2023

pycaracal has been deprecated: dioptra-io/caracal#58

Instead call caracal in a subprocess. This simplifies the installation of Iris, especially for platforms where the pycaracal binary wheels were not available.

@maxmouchet maxmouchet force-pushed the max/migrate-to-caracal branch 2 times, most recently from 814515a to 5ca7f1e Compare October 27, 2023 22:50
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Files Coverage Δ
iris/agent/main.py 85.71% <100.00%> (ø)
iris/agent/settings.py 89.28% <ø> (-2.39%) ⬇️
iris/commons/dependencies.py 96.15% <100.00%> (ø)
iris/commons/redis.py 100.00% <100.00%> (+0.78%) ⬆️
iris/agent/backend/caracal.py 85.10% <79.41%> (-8.90%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@maxmouchet maxmouchet merged commit 6cbe694 into main Oct 27, 2023
2 checks passed
@maxmouchet maxmouchet deleted the max/migrate-to-caracal branch October 27, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant