Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same container image versions as infrastructure #170

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

SaiedKazemi
Copy link
Member

Iris could not successfully restart after upgrading the Iris server (applying security patches and rebooting) although GitHub can successfully install and run Iris when testing pull requests. This is because the test environment uses different container image versions than the Iris server.

This commit changes docker-compose.yml to use the same container image versions that the test environment uses.

Iris could not successfully restart after upgrading the
Iris server (applying security patches and rebooting)
although GitHub can successfully install and run Iris when
testing pull requests.  This is because the test environment
uses different container image versions than the Iris server.

This commit changes docker-compose.yml to use the same
container image versions that the test environment uses.
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79caa55) 93.86% compared to head (066dc75) 93.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files          54       54           
  Lines        2168     2168           
=======================================
  Hits         2035     2035           
  Misses        133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maxmouchet maxmouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxmouchet maxmouchet merged commit 9dbf076 into main Dec 18, 2023
5 checks passed
@maxmouchet maxmouchet deleted the saied-docker-compose branch December 18, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants