more mypy checks, docopt-->argparse, formatting, cleanup, ci improvements, ... #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goerlibe
force-pushed
the
mypy_cleanup
branch
7 times, most recently
from
06cfee9
to
b8696db
Compare
goerlibe
force-pushed
the
mypy_cleanup
branch
2 times, most recently
from
f8e776b
to
60f5ad1
Compare
goerlibe
force-pushed
the
mypy_cleanup
branch
from
2a46def
to
54cb5d5
Compare
goerlibe
commented
Sep 11, 2023
goerlibe
commented
Sep 11, 2023
goerlibe
force-pushed
the
mypy_cleanup
branch
from
54cb5d5
to
8f1acce
Compare
|
I think the settings need some change to accomodate for the removed "CI Tests Successful" job. However I do not have sufficient access rights for that. I've changed the settings accordingly. "CI Tests Successful" is no longer necessary. Instead, "Execute CI Tests" is now considered. Best |
goerlibe
force-pushed
the
mypy_cleanup
branch
8 times, most recently
from
c5d7b29
to
2a03053
Compare
goerlibe
force-pushed
the
mypy_cleanup
branch
from
2a03053
to
d185b6d
Compare
|
added 13 commits
September 14, 2023 13:46
…e remains stable though) UNTESTED!
goerlibe
force-pushed
the
mypy_cleanup
branch
from
43b4bd6
to
3bf0a4a
Compare
goerlibe
force-pushed
the
mypy_cleanup
branch
from
3bf0a4a
to
99809b8
Compare
|
unless you see any issues, I think this is ready for merging. @lukasrothenberger |
lukasrothenberger
previously approved these changes
Sep 14, 2023
lukasrothenberger
approved these changes
Sep 14, 2023
| if cast(Workload, node_data).parallelizable_workload is None | ||
| else cast(int, cast(Workload, node_data).parallelizable_workload) | ||
| ) | ||
| min_wl = (node_data.sequential_workload or 0) + (node_data.parallelizable_workload or 0) |
There was a problem hiding this comment.
nice solution! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.