FIX: BBCode parsing specs #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZogStriP
commented
May 24, 2024
| end | ||
|
|
||
| it "works with status attribute" do | ||
| post = create_post_with_event(user, 'status="private"').reload | ||
| expect(post.event.status).to eq(DiscoursePostEvent::Event.statuses[:private]) | ||
|
|
||
| post = create_post_with_event(user, 'status=""').reload |
There was a problem hiding this comment.
Removed these specs which aren't supported anymore.
ZogStriP
commented
May 24, 2024
| end | ||
|
|
||
| it "works with url attribute" do | ||
| url = "https://www.discourse.org" | ||
|
|
||
| post = create_post_with_event(user, "url=\"#{url}\"").reload | ||
| expect(post.event.url).to eq(url) | ||
|
|
||
| post = create_post_with_event(user, 'url=""').reload |
There was a problem hiding this comment.
Removed these specs which aren't supported anymore.
ZogStriP
commented
May 24, 2024
| expect(post.event.raw_invitees).to match_array(%w[euro america]) | ||
|
|
||
| post = create_post_with_event(user, 'status="private" allowedGroups=""').reload |
There was a problem hiding this comment.
Removed these specs which aren't supported anymore.
ZogStriP
commented
May 24, 2024
| expect(post.event.raw_invitees).to eq([]) | ||
|
|
||
| post = create_post_with_event(user, 'status="private" allowedGroups=').reload |
There was a problem hiding this comment.
Removed these specs which aren't supported anymore.
Requires discourse/discourse#27173 to be merged. Will add a `.discourse-compatibility` once merged.
ZogStriP
force-pushed
the
fix-bbcode-specs
branch
from
8bac689
to
190765d
Compare
arpitjalan
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires discourse/discourse#27173 to be merged.
Will add a
.discourse-compatibilityonce merged.