Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip stat call / throwing an exception when source files don't exist in v3 (Backport of #225) #264

Open
wants to merge 1 commit into
base: v3.15
Choose a base branch
from

Conversation

BPScott
Copy link

@BPScott BPScott commented Dec 19, 2023

I saw that in #260 @jonaskello is amenable to backporting features to the v3 branch, as the majority of users are still on v3, (mostly thanks to the strong backwards compatibility promises made by eslint-plugin-import).

This PR backports the performance improving #225 to v3.15 - no editing needed, it's just a cherry-pick.

Details in #225 suggests that this offers a solid speed improvement. import-js/eslint-plugin-import#2654 proposed updating tsconfig-paths from v3 to v4 in eslint-plugin-import as this change resulted in a 10-20% speed improvement in large repositories - I suspect in large part due to this one performance change. That PR was ultimately rejected due to eslint-plugin-import supporting a long tail of node versions, and thus wanting to stay on tsconfig-paths v3. eslint-plugin-import's author suggested backporting the performance fix to v3 so they could take advantage of it, so here I am.

#225 was released as a patch version, so I assume this would be too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants