updated default shell to /bin/sh

djcass44 · Oct 17, 2023 · 1477338 · 1477338
1 parent 1ec4e44
commit 1477338
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/pkg/linuxutil/passwd.go b/pkg/linuxutil/passwd.go
@@ -13,6 +13,8 @@ import (
 	"strings"
 )
 
+const DefaultShell = "/bin/sh"
+
 // NewUser adds an entry to the /etc/passwd file to create a new Linux
 // user.
 func NewUser(ctx context.Context, rootfs fs.FullFS, username string, uid int) error {
@@ -39,7 +41,7 @@ func NewUser(ctx context.Context, rootfs fs.FullFS, username string, uid int) er
 		log.Error(err, "failed to open passwd file")
 		return err
 	}
-	if _, err := file.Write([]byte(fmt.Sprintf("%s:x:%d:0:Linux User,,,:/home/%s:/sbin/nologin\n", username, uid, username))); err != nil {
+	if _, err := file.Write([]byte(fmt.Sprintf("%s:x:%d:0:Linux User,,,:/home/%s:%s\n", username, uid, username, DefaultShell))); err != nil {
 		log.Error(err, "failed to write to passwd file")
 		return err
 	}

diff --git a/pkg/linuxutil/testdata/existing b/pkg/linuxutil/testdata/existing
@@ -25,4 +25,4 @@ ntp:x:123:123:NTP:/var/empty:/sbin/nologin
 smmsp:x:209:209:smmsp:/var/spool/mqueue:/sbin/nologin
 guest:x:405:100:guest:/dev/null:/sbin/nologin
 nobody:x:65534:65534:nobody:/:/sbin/nologin
-somebody:x:1001:0:Linux User,,,:/home/somebody:/sbin/nologin
+somebody:x:1001:0:Linux User,,,:/home/somebody:/bin/sh
diff --git a/pkg/linuxutil/testdata/single b/pkg/linuxutil/testdata/single
@@ -1 +1 @@
-somebody:x:1001:0:Linux User,,,:/home/somebody:/sbin/nologin
+somebody:x:1001:0:Linux User,,,:/home/somebody:/bin/sh