fix: add guards for MagickImage.BilateralBlur

[Gounlaf]

👋

• https://github.com/ImageMagick/ImageMagick/blob/0c0f0a4e832271a1a37b872e8b76c100e81945c2/MagickCore/effect.c#L896-L897 requires size_t for witdh & height ; some lines later, they are bounded to 1 at minimum
• no checks done on https://github.com/dlemstra/Magick.Native/blob/d0a63d7f3852652c7c5c68c1950a00de015878f5/src/Magick.Native/MagickImage.c#L823-L832
• no checks done on binding, except casting to UInt (so >= 0)

  Magick.NET/src/Magick.NET/Native/MagickImage.cs

  Lines 4157 to 4182 in 6035129

  	public void BilateralBlur(int width, int height, double intensitySigma, double spatialSigma)
  	{
  	IntPtr exception = IntPtr.Zero;
  	IntPtr result;
  	#if PLATFORM_AnyCPU
  	if (Runtime.IsArm64)
  	#endif
  	#if PLATFORM_arm64 || PLATFORM_AnyCPU
  	result = NativeMethods.ARM64.MagickImage_BilateralBlur(Instance, (UIntPtr)width, (UIntPtr)height, intensitySigma, spatialSigma, out exception);
  	#endif
  	#if PLATFORM_AnyCPU
  	else if (Runtime.Is64Bit)
  	#endif
  	#if PLATFORM_x64 || PLATFORM_AnyCPU
  	result = NativeMethods.X64.MagickImage_BilateralBlur(Instance, (UIntPtr)width, (UIntPtr)height, intensitySigma, spatialSigma, out exception);
  	#endif
  	#if PLATFORM_AnyCPU
  	else
  	#endif
  	#if PLATFORM_x86 || PLATFORM_AnyCPU
  	result = NativeMethods.X86.MagickImage_BilateralBlur(Instance, (UIntPtr)width, (UIntPtr)height, intensitySigma, spatialSigma, out exception);
  	#endif
  	CheckException(exception, result);
  	if (result != IntPtr.Zero)
  	Instance = result;
  	}

Same could be done for intensitySigma & spatialSigma, but ImageMagick always multiply each param by itself, making them always positive.

On one hand, it's already "safe".
On the other hand, there is nothing (at least comments) telling it must be > 0.

Regards.

Edit: added the exception tag that was missing (even without my modifications)

[dlemstra]

In your other PR you used Throw.IfNegative. I think I would prefer to have a consistent api and also use that here. And I don't think I would want to have the (>0) in the xml comments. And you should also update the interface to add this: /// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>.

[Gounlaf]

PR Updated according to your requests 🙂

[dlemstra]

Could you add a newline after the Thow's? I do that in the rest of the library.

p.s. I missed that in your other pr...

[Gounlaf]

✔️