PTFM-12951 Move EE dependency installation code into dxpy #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -205,12 +204,13 @@ def string_buffer_length(buf): | |||
| return buf_len | |||
|
|
|||
| def normalize_time_input(t, future=False): | |||
| ''' Converts inputs such as: | |||
| """ | |||
| Converts inputs such as: | |||
There was a problem hiding this comment.
In general it would be nice to break out cosmetic changes from the real substantive changes.
|
@psung, I addressed your comments, please take another look. |
|
LGTM |
|
Squash merged in b2c0c99, thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@psung, please review.
This is the SDK portion of the move. The EM/EE portion will involve deleting the EM code and changing dx-prepare-exec-env to use this code.
Also some minor formatting changes, and a change to dx-log-stream to remove code that is unneeded after dx-exec-helper changes (which will land together with the other EM/EE changes above).