Enable configs.file's on remote docker hosts #11871
Open
+155
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
reviewed
May 31, 2024
andoks
commented
May 31, 2024
Copy configs.file's and secrets.file's instead of bind-mounting them to make it possible to use file configs when working with remote docker hosts (like setting DOCKER_HOST to a ssh address or setting docker context) Includes support for config.files and secrets.files as directories. Note that file.Content as source of secrets is denied elsewhere with the error "validating docker-compose.yml: secrets.content_secret Additional property content is not allowed" implements: docker#11867
andoks
force-pushed
the
topic/andoks/#11867-support-configs-files-on-remote-docker-hosts
branch
from
6638c2f
to
d9dd161
Compare
andoks
commented
Jun 1, 2024
| file := project.Secrets[config.Source] | ||
| var tarArchive bytes.Buffer | ||
| var err error | ||
| switch { |
There was a problem hiding this comment.
Note: not handling file.Content as this seems to be rejected some other place, causing the printout "validating docker-compose.yml: secrets.content_secret Additional property content is not allowed"
andoks
commented
Jun 1, 2024
| } | ||
|
|
||
| func makeTarFileEntryParams(config types.FileReferenceConfig) (mode int64, uid, gid int, err error) { | ||
| mode = 0o444 |
There was a problem hiding this comment.
❓ should the default mode be different for secrets compared to configs?
andoks
commented
Jun 1, 2024
| err = fs.WalkDir(subdir, ".", func(filePath string, d fs.DirEntry, err error) error { | ||
| header := &tar.Header{ | ||
| Name: filepath.Join(config.Target, filePath), | ||
| Mode: mode, |
There was a problem hiding this comment.
❓ Should directories have the same mode as files? Or should they perhaps have the exec bit set for the owner/group/other to access them?
|
@ndeloof left you a few questions in the review |
|
any ETA? |
See discussion in #11867 - it might take some time to decide how to proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Copy configs.file's instead of bind-mounting them to make it possible to use file configs when working with remote docker hosts (like setting DOCKER_HOST to a ssh address or setting docker context)
Related issue
implements: #11867
(not mandatory) A picture of a cute animal, if possible in relation to what you did
